Support This Project

Changeset 2022

Show
Ignore:
Timestamp:
08/14/08 18:27:55 (4 months ago)
Author:
virdiq
Message:

Fix incorrect assumptions in do_rmdir that GetGroupByID and GetUserByID always return valid structs.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/libwzd-core/wzd_ClientThread.c

    r2020 r2022  
    14331433int do_rmdir(UNUSED wzd_string_t *name, wzd_string_t * arg, wzd_context_t * context) 
    14341434{ 
    1435   char path[WZD_MAX_PATH], buffer[WZD_MAX_PATH]; 
     1435  char path[WZD_MAX_PATH]; 
     1436  char buffer[WZD_MAX_PATH]; 
    14361437  fs_filestat_t s; 
    14371438  int ret; 
    1438   wzd_user_t * user; 
     1439  wzd_user_t * user = NULL; 
     1440  wzd_group_t * group = NULL; 
    14391441  const char *param; 
    14401442 
     
    14471449 
    14481450  user = GetUserByID(context->userid); 
     1451  if (!user) 
     1452    goto label_error_rmdir; 
    14491453 
    14501454  if ( !(user->userperms & RIGHT_RMDIR) ) { ret = E_NOPERM;; goto label_error_rmdir; } 
     
    14891493 
    14901494    { 
    1491       const char *groupname=NULL; 
    14921495      char tbuf[WZD_MAX_PATH], path[WZD_MAX_PATH]; 
    14931496 
    14941497      if (user->group_num > 0) { 
    1495         groupname = GetGroupByID(user->groups[0])->groupname
     1498        group = GetGroupByID(user->groups[0])
    14961499      } 
    14971500 
     
    15081511          path, /* ftp-absolute path */ 
    15091512          user->username, 
    1510           (groupname)?groupname:"No Group", 
    1511           user->tagline 
     1513          group ? group->groupname : "No group", 
     1514          *(user->tagline) ? user->tagline : "No tagline" 
    15121515          ); 
    15131516    }